Let stack_parameters support symbol hash keys, for now #18373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Service dialog options keys are supposed to be in String. But for some reason, API sends those keys in symbol when ordering a Service from global region. Before we find out where those keys are duplicated in symbol via API, we have to work around it. https://bugzilla.redhat.com/show_bug.cgi?id=1654999
|
Checked commit lfu@5cf587c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
d-m-u
approved these changes
Jan 21, 2019
tinaafitz
approved these changes
Feb 7, 2019
|
@mkanoor Please review. |
mkanoor
approved these changes
Feb 7, 2019
simaishi
pushed a commit
that referenced
this pull request
Feb 7, 2019
Let stack_parameters support symbol hash keys, for now (cherry picked from commit 6fa6891) https://bugzilla.redhat.com/show_bug.cgi?id=1673748
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service dialog options keys are supposed to be in String. But for some reason, API sends those keys in symbol when ordering a Service from global region.
Before we find out where those keys are duplicated in symbol via API, we have to work around it.
https://bugzilla.redhat.com/show_bug.cgi?id=1654999
@miq-bot assign @gmcculloug
@miq-bot add_label bug, gaprindashvili/yes, hammer/yes, services, orchestration
cc @jrafanie