Add retired to service active states

[d-m-u]

We validate the request state in

manageiq/app/models/miq_retire_request.rb

Line 3 in 33d994a

validates :request_state, :inclusion => { :in => %w(pending finished) + ACTIVE_STATES, :message => "should be pending, #{ACTIVE_STATES.join(", ")} or finished" }

but vms can be provisioned, so the list should include that, and services can be retired, so it should include that too.

Should've been a part of #18283.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1666834

[d-m-u]

@miq-bot add_reviewer @tinaafitz
@miq-bot add_reviewer @bdunne
@miq-bot add_reviewer @mkanoor
@miq_bot add_label bug

[d-m-u]

@miq-bot add_label bug
Don't have one yet, will update when I do.

[bdunne]

Not for this PR, but "retired" doesn't sound like an active state, a better name for the validation to use might be VALID_STATES.

[d-m-u]

Haha, I told her about this yesterday.

[tinaafitz]

@d-m-u @bdunne I know it looks odd, and we can rename it in the future, but retired is an active state.
Reconfigured and migrated are active states as well.

Most of our lifecycle state machines have multiple states for each of 3 phases:

1. Pre-processing
2. Execution/Check Execution <---- the state would be provisioned/retired/reconfigured/migrated here
3. Post-processing <----- It still has to process these states before it can be finished.
   The state is "finished" at the end of the state machine.

[miq-bot]

Checked commit d-m-u@a6cc73c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

[simaishi]

@d-m-u assume hammer/yes?

[d-m-u]

Yup, sorry @simaishi
@miq-bot add_label hammer/yes

[simaishi]

Hammer backport details:

$ git log -1
commit 5f1d45b83cafc7809a498a5f2098c760979f1333
Author: Brandon Dunne <[email protected]>
Date:   Sat Jan 12 08:34:48 2019 -0500

    Merge pull request #18348 from d-m-u/adding_provisioned_to_vm_active_states
    
    Add retired to service active states
    
    (cherry picked from commit 35c0f1787c52a38ae4dc8d220a93e58a84ad628b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1672700