Restore an event for the main app logs' disk usage #18340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
force-pushed
the
restore_app_log_usage_event
branch
from
0d72465 to
7370e1c
Compare
https://bugzilla.redhat.com/show_bug.cgi?id=1658670 Although removed in ManageIQ#5551 and related appliance PRs, it's quite possible that users could mount their own disk at this moint point and would want to monitor for this event. It's trivial processing to skip it if they don't have a disk mounted at this location. The description of the event needed to be changed to include the full log path to make it less ambiguous with the other "log" disk usage events.
jrafanie
force-pushed
the
restore_app_log_usage_event
branch
from
7370e1c to
86c3500
Compare
|
Checked commit jrafanie@86c3500 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
approved these changes
Jan 8, 2019
|
@carbonin thanks for doing the labels 😅 |
simaishi
pushed a commit
that referenced
this pull request
Feb 5, 2019
Restore an event for the main app logs' disk usage (cherry picked from commit bc8fadc) https://bugzilla.redhat.com/show_bug.cgi?id=1672698
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1658670
Although removed in #5551 and
related appliance PRs, it's quite possible that users could mount their own
disk at this moint point and would want to monitor for this event. It's
trivial processing to skip it if they don't have a disk mounted at this
location.
The description of the event needed to be changed to include the full
log path to make it less ambiguous with the other "log" disk usage events.