Rename WebSocketWorker to RemoteConsoleWorker

[skateman]

Since the WebSocketWorker will not support only WebSockets, but other (purr, cockpit) protocols as well and it no longer contains ActionCable it is more meaningful to name it RemoteConsoleWorker as it serves remote consoles. I also changed the websocket role to remote_console.

Parent issue: #18300
UI part: ManageIQ/manageiq-ui-classic#5136
Schema: ManageIQ/manageiq-schema#319

@miq-bot add_label hammer/no
@miq-bot add_reviewer @kbrock
@miq-bot add_reviewer @jrafanie
@miq-bot add_reviewer @djberg96
@miq-bot add_reviewer @Fryguy

[jrafanie]

Parent issue: #18300
UI part: ManageIQ/manageiq-schema#319
Schema: ManageIQ/manageiq-schema#319

The links are duplicated in the description

[jrafanie]

I'm feel like there are some extra migrations necessary because of the role name change, but I'm not sure about it...

If we want to rename the role internal name "websocket", I'd think we need to walk settings and convert the roles so customers who have it enabled now will have it enabled after migrating. Something like this

[jrafanie]

This fixture gets seeded at boot into the server_roles table. I don't know if we'd have to drop the existing websocket row from that table.

It might be fine without dropping the role. I don't know if we present the existing server roles rows in the UI.

[skateman]

Well, as we did the migrations, I think this can just go.

[jrafanie]

I'd think we need a migration to walk their settings changes to see if they have any changes to the old websocket_worker role and change that change to the new name. Similar as below for the role name.

[skateman]

Done!

[skateman]

@jrafanie thanks, I'm working on these migrations as I'm trying to start up an appliance with the changes 😅

[miq-bot]

Checked commit skateman@e518b13 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
14 files checked, 7 offenses detected

app/models/miq_server/role_management.rb

• ❗ - Line 52, Col 38 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 53, Col 38 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 54, Col 38 - Style/RedundantSelf - Redundant self detected.
• ❗ - Line 55, Col 38 - Style/RedundantSelf - Redundant self detected.

lib/vmdb/loggers.rb

• ❗ - Line 23, Col 34 - Style/GlobalVars - Do not introduce global variables.
• ❗ - Line 51, Col 7 - Style/GlobalVars - Do not introduce global variables.

spec/models/miq_remote_console_worker/runner_spec.rb

• ❗ - Line 20, Col 9 - Style/NegatedIf - Favor unless over if for negative conditions.

[skateman]

Migrations are done, I asked @simaishi to make a build which I've tested. Also took the most recent nightly build (8th of January), did some changes in the settings and ran the migrations...everything works as it should. So this is now ready for review with the rest.

[jrafanie]

🎉