-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for exporting and importing reports #18284
Conversation
@branic I just got to this today. Looks good so far. Need to looks at the tests... |
@@ -0,0 +1,67 @@ | |||
describe TaskHelpers::Exports::ServiceDialogs do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be TaskHelpers::Exports::Reports
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, you're correct. That's what I get for copy/pasting.
@branic This looks good. Can you please take care of the rubocop issues with trailing spaces in the report yamls? Once that's done I'll merge. Thanks 👍 |
Checked commit https://github.com/branic/manageiq/commit/5ee0142f231c4f0230d407bce9b6d6170e245e97 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@gtanzillo Fixed the rubocop trailing spaces and squashed all the commits into one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Thanks @branic
These rake scripts and classes provide functionality for exporting/importing of the following ManageIQ object types:
This PR uses the framework that was implemented for PRs #14126, #15256, #16717, and others to export/import other ManageIQ object types.
These scripts are based on the CFME RH Consulting Scripts and are used by Red Hat consultants to enable storing customizations in Git and maintaining customizations between environments (e.g. dev/qa/prod) for an SDLC lifecycle.
Links [Optional]
Steps for Testing/QA [Optional]
Exporting
Importing