Add more ConversionHost validations

[djberg96]

As I was doing some general testing with various POST operations with the REST API for conversion hosts, I realized there were almost no validations on the model. This PR adds some validations to a few columns, specifically the following:

• name - must be present
• resource_type - must be present and "Vm" or "Host"
• resource_id - must be present
• address - must be present, unique, and be a valid IP address

I'm not sure about the uniqueness constraint on the address field and/or if there are any other validations that we would like to see added, so a WIP for now.

[jameswnl]

Now address is enforced to be present and in the format of IP and coming from the resource.ipaddresses, do we still need this ipaddress method?

[djberg96]

Probably not, but let's refactor in a separate PR. :)

[miq-bot]

Checked commits https://github.com/djberg96/manageiq/compare/58bc0e469ba91e6448e3db42d6e95938097cc9e4~...a519f75360034e13d064ac0ab5d6ff78b9ee143a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 7 offenses detected

app/models/conversion_host.rb

• ❗ - Line 18, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 19, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 20, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/models/service_template_transformation_plan_request_spec.rb

• ⚠️ - Line 100, Col 9 - Lint/UselessAssignment - Useless assignment to variable - conversion_host.
• ⚠️ - Line 136, Col 9 - Lint/UselessAssignment - Useless assignment to variable - conversion_host.
• ⚠️ - Line 64, Col 9 - Lint/UselessAssignment - Useless assignment to variable - conversion_host.

spec/models/service_template_transformation_plan_task_spec.rb

• ❗ - Line 22, Col 26 - Layout/SpaceBeforeBlockBraces - Space missing to the left of {.

[djberg96]

@jameswnl @agrare I'm going to have to rework this, because it's having a ripple effect through the specs anywhere there's a ConversionHost factory and/or anything relying on the current ipaddresses method. It's going to have to be less strict.

[djberg96]

@jameswnl @fdupont-redhat Closed in favor of #18277