Include /etc/manageiq/postgresql.conf.d/ directory to log collection #18262

yrudman · 2018-12-04T13:11:37Z

Include /etc/manageiq/postgresql.conf.d/* to log collection

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1652116

@miq-bot add-label bug, hammer/yes

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1652116

…lection

miq-bot · 2018-12-04T13:20:48Z

Checked commits yrudman/manageiq@673faef~...92d7a0b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

yrudman · 2018-12-04T14:51:20Z

@jrafanie could you review

jrafanie · 2018-12-04T16:32:05Z

app/models/miq_server/log_management.rb

@@ -80,7 +80,7 @@ def pg_log_patterns
    return [] unless pg_data

    pg_data = Pathname.new(pg_data)
-    [pg_data.join("*.conf"), pg_data.join("pg_log/*")]
+    [pg_data.join("*.conf"), pg_data.join("pg_log/*"), Pathname.new("/etc/manageiq/postgresql.conf.d/*")]


Is /etc/manageiq/postgresql.conf.d/ the same everywhere? If so, I'm good with this change. We might want to externalize this path as a contanst like we do with pg_data_dir but if this is the only caller of it, it's fine to be like this for now.

yes, path is pre-defined and the same in different repos: https://github.com/ManageIQ/manageiq-appliance/tree/master/COPY/etc/manageiq/postgresql.conf.d ,

https://github.com/ManageIQ/manageiq-appliance/blob/72e0313e25395f6396f54ca9ddb755afcd62bdf5/TEMPLATE/var/opt/rh/rh-postgresql95/lib/pgsql/data/postgresql.conf#L615 ,

https://github.com/ManageIQ/manageiq-gems-pending/blob/ea3adf45d9aa2eb569c3d379bd3e0d4a509f4098/spec/support/mixins/pg_environment_updater.rb#L38

It will be the only caller in ManageIQ/manageiq

…nf_d-directory-to-log-collection Include /etc/manageiq/postgresql.conf.d/ directory to log collection (cherry picked from commit e91f6b8) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1672694

simaishi · 2019-02-05T23:13:35Z

Hammer backport details:

$ git log -1
commit 0c2fad6f2c92e8438162d3433bb4a685b30910ee
Author: Joe Rafaniello <[email protected]>
Date:   Tue Dec 4 12:25:23 2018 -0500

    Merge pull request #18262 from yrudman/add-etc_manageiq_postgresql_conf_d-directory-to-log-collection
    
    Include  /etc/manageiq/postgresql.conf.d/ directory to log collection
    
    (cherry picked from commit e91f6b80db30a44f90379ffcf8bb57412c9eab19)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1672694

yrudman added 2 commits December 4, 2018 08:02

include /etc/manageiq/postgresql.conf.d/* in log collection

673faef

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1652116

rspec to check if /etc/manageiq/postgresql.conf.d/ included in og col…

92d7a0b

…lection

miq-bot added bug hammer/yes labels Dec 4, 2018

jrafanie reviewed Dec 4, 2018

View reviewed changes

jrafanie self-assigned this Dec 4, 2018

jrafanie merged commit e91f6b8 into ManageIQ:master Dec 4, 2018

jrafanie added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 4, 2018

yrudman deleted the add-etc_manageiq_postgresql_conf_d-directory-to-log-collection branch December 4, 2018 17:48

simaishi added hammer/backported and removed hammer/yes labels Feb 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include /etc/manageiq/postgresql.conf.d/ directory to log collection #18262

Include /etc/manageiq/postgresql.conf.d/ directory to log collection #18262

yrudman commented Dec 4, 2018

miq-bot commented Dec 4, 2018

yrudman commented Dec 4, 2018

jrafanie Dec 4, 2018

yrudman Dec 4, 2018

simaishi commented Feb 5, 2019

Include /etc/manageiq/postgresql.conf.d/ directory to log collection #18262

Include /etc/manageiq/postgresql.conf.d/ directory to log collection #18262

Conversation

yrudman commented Dec 4, 2018

miq-bot commented Dec 4, 2018

yrudman commented Dec 4, 2018

jrafanie Dec 4, 2018

Choose a reason for hiding this comment

yrudman Dec 4, 2018

Choose a reason for hiding this comment

simaishi commented Feb 5, 2019