Fix miq request ownership #18257
Merged
Fix miq request ownership #18257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
fix-miq_request-ownership
branch
from
1cc1575 to
b1f7a3d
Compare
|
Checked commits kbrock/manageiq@c7d2cdc~...b1f7a3d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@kbrock @gtanzillo |
lpichler
reviewed
Dec 4, 2018
There was a problem hiding this comment.
👍 LGTM, thanks @kbrock
making a note to update factories in these specs when this(Support more regions in FactoryGirl's factories) will be merged (and other PR
s)
simaishi
pushed a commit
that referenced
this pull request
Dec 6, 2018
Fix miq request ownership (cherry picked from commit aa6fba5) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1647169
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Dec 14, 2018
Fix miq request ownership (cherry picked from commit aa6fba5) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656170
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, MiqRequests only show requests created in the same region.
This works most of the time except for a rollup (aka reporting) region.
You see, we have different user records for each region. They have the same
userid(aka the string login name), but theidis different.Requests created in this region are associated with the user from this region, and requests created in another region are associated with the user from the other region.
Followup to #18245 (added specs)
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1647169
Before
For the request screen, we only showed requests associated with the currently logged in user.
Requests from other regions were not associated with this user and did not show.
After
For the request screen, we now only show requests associated with the currently logged in
userid(the string you use to login).Requests from other regions are associated with a different user, but the
useridmatch, so they are now shown.The
OwnershipMixinusesuseridto store object ownership.The MiqRequest needed to overrides these methods since ownership is stored in
requester_id.The new methods have been changed to still be based upon
requester_id, but the code is now more similar to theOwnershipMixinversion.