Fix Relationship#grandchildren #18239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLaMuro
approved these changes
Nov 28, 2018
kbrock
force-pushed
the
relationship_grandchildren_fix
branch
from
c6d3285 to
d3ae76d
Compare
grandchild_conditions did not properly building sql. The sql would never return any rows Now it returns the correct nodes
kbrock
force-pushed
the
relationship_grandchildren_fix
branch
from
d3ae76d to
fd1a3b4
Compare
|
Checked commit kbrock@fd1a3b4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@kbrock Why hammer/no? |
1 task
simaishi
pushed a commit
that referenced
this pull request
Nov 30, 2018
Fix Relationship#grandchildren (cherry picked from commit bf46b38)
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulled out of #18235
grandchild_conditionsdid not properly building sql.The sql would never return any rows
before
( relationship LIKE "child_ancestry/%" -- grand child or lower AND NOT relationship LIKE "child_ancestry/%" -- NOT grand child or lower (BUG) )after
( relationship LIKE "child_ancestry/%" -- grand child or lower AND NOT relationship LIKE "child_ancestry/%/%" -- NOT great grand child or lower )Now it returns the correct nodes.
Also of note, this now generates the same sql declared in this method's comment.