Fix supports_capture assuming MetricsCapture class #18233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
bz_1638045_fix_supports_capture
branch
from
cb25ab0 to
1a82027
Compare
agrare
force-pushed
the
bz_1638045_fix_supports_capture
branch
from
1a82027 to
8f33539
Compare
The supports :capture block assumes that the MetricsCapture class always exists even if metrics capture is unsupported which is not the case. Modify the block to check for the existence of the metrics capture class before checking its instance methods. Also fix the unsupported_reason_add setting the reason to the wrong feature key (:metrics when should have been :capture). Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1638045
agrare
force-pushed
the
bz_1638045_fix_supports_capture
branch
from
8f33539 to
6e33bbe
Compare
|
Checked commit agrare@6e33bbe with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@agrare |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2018
Fix supports_capture assuming MetricsCapture class (cherry picked from commit 603d59a) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1638045
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The supports :capture block assumes that the MetricsCapture class always
exists even if metrics capture is unsupported which is not the case.
Modify the block to check for the existence of the metrics capture class
before checking its instance methods.
Also fix the unsupported_reason_add setting the reason to the wrong
feature key (:metrics when should have been :capture).
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1638045