Add conversion_host option to the SupportsFeatureMixin module

[djberg96]

This PR adds the conversion_host option to the SupportsFeature mixin for conversion host support (or not).

The idea here is that we can then use this for V2V, where individual resources (VM or possibly Host) within each provider repo can put this within their respective vm.rb or host.rb file(s). This will help us govern behavior elsewhere within the codebase via supports :conversion_host or supports_not :conversion_host.

With this in place, the ManageIQ REST API can also take advantage of it in order to check for support. See here for an example of where this is already used:

https://github.com/ManageIQ/manageiq-api/blob/master/app/controllers/api/subcollections/security_groups.rb#L12

https://bugzilla.redhat.com/show_bug.cgi?id=1622728
https://bugzilla.redhat.com/show_bug.cgi?id=1695810

[djberg96]

@miq-bot add_reviewer @jameswnl

[djberg96]

@miq-bot add_reviewer @agrare

[agrare]

@djberg96 is the idea to check if it is possible to enable a resource to be a conversion host, or to check if one is a conversion host?

[djberg96]

@agrare The idea is to check if it's possible to enable a resource to be a conversion host.

To see if a resource is a conversion host we can check to see if there's an existing relationship to the conversion_host table. That, or perhaps there's some other attribute on the v2v side, can't remember right now.

[agrare]

@djberg96 yeah okay good, since we already have has_one conversion_host on vms and hosts 👍

[miq-bot]

Checked commits https://github.com/djberg96/manageiq/compare/9e069e08bd582cbc5885f226bb2e63c4ac4b3d81~...3e2a6fbf9ebb9fb09083b1a6d25d71e275e9c464 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[djberg96]

@miq-bot add_label hammer/yes

[simaishi]

Hammer backport details:

$ git log -1
commit 48dbd21a87b5af4caf6a9ce43a9892d614228384
Author: Adam Grare <[email protected]>
Date:   Mon Nov 26 14:26:22 2018 -0500

    Merge pull request #18232 from djberg96/supports_conversion_host
    
    Add conversion_host option to the SupportsFeatureMixin module
    
    (cherry picked from commit c9d1e4d6d7e1b52a8bf19687918e844d924909ec)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1694229

[simaishi]

Reverted the backport:

commit 8aa6215951a438d4fbf3f84f2e3fd9b3f1dea9b7
Author: Satoe Imaishi <[email protected]>
Date:   Mon Apr 1 11:31:18 2019 -0400

    Revert "Merge pull request #18232 from djberg96/supports_conversion_host"
    
    This reverts commit 48dbd21a87b5af4caf6a9ce43a9892d614228384.

[simaishi]

Hammer backport details:

$ git log -1
commit 958ec645785de184730c21a209f2f68cd1fd6981
Author: Adam Grare <[email protected]>
Date:   Mon Nov 26 14:26:22 2018 -0500

    Merge pull request #18232 from djberg96/supports_conversion_host
    
    Add conversion_host option to the SupportsFeatureMixin module
    
    (cherry picked from commit c9d1e4d6d7e1b52a8bf19687918e844d924909ec)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1702019