Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ovirt Cluster through Ansible #18220

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Upgrade Ovirt Cluster through Ansible #18220

merged 1 commit into from
Nov 21, 2018

Conversation

borod108
Copy link

@borod108 borod108 commented Nov 20, 2018 •
edited
Loading

Add method to upgrade cluster using ovirt-ansible-cluster-upgrade
role.

Required for implementing: https://bugzilla.redhat.com/show_bug.cgi?id=1644605

@agrare agrare self-assigned this Nov 20, 2018
@agrare
Copy link
Member

agrare commented Nov 20, 2018

app/models/cluster_upgrade_mixin.rb

Can you move this under app/models/ems_cluster/upgrade.rb since it isn't really a mixin its just being included in one model

@borod108 borod108 force-pushed the rfe/cluster_upgrade_with_ansible branch from 33059f6 to ef13925 Compare November 20, 2018 14:50
@agrare agrare changed the title Upgrade Ovirt Cluster through Ansibel Upgrade Ovirt Cluster through Ansible Nov 20, 2018
@agrare
Copy link
Member

agrare commented Nov 20, 2018

Can you reword the commit to fix the typo? Upgrade Ovirt Cluster through Ansibel

Upgrade Ovirt Cluster through Ansible
9b47ffa 
Add method to upgrade cluster using ovirt-ansible-cluster-upgrade
role.
@borod108 borod108 force-pushed the rfe/cluster_upgrade_with_ansible branch from ef13925 to 9b47ffa Compare November 20, 2018 15:19
@miq-bot
Copy link
Member

miq-bot commented Nov 20, 2018

Checked commit borod108@9b47ffa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🍰

@borod108 borod108 closed this Nov 21, 2018
@borod108 borod108 reopened this Nov 21, 2018
agrare
agrare approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 temporarily for backport, lets follow up with creating STI sub-classes for rhev/vmware/scvmm

@agrare agrare merged commit 9f1954a into ManageIQ:master Nov 21, 2018
@agrare agrare added this to the Sprint 100 Ending Dec 3, 2018 milestone Nov 21, 2018
@borod108
Copy link
Author

borod108 commented Dec 3, 2018

@miq-bot add-label hammer/yes

simaishi pushed a commit that referenced this pull request Dec 3, 2018
@agrare @simaishi
Merge pull request #18220 from borod108/rfe/cluster_upgrade_with_ansible
98c36b5 
Upgrade Ovirt Cluster through Ansible

(cherry picked from commit 9f1954a)
@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2018

Hammer backport details:

$ git log -1
commit 98c36b571bccded5dde0379358478f25ac0b8e6b
Author: Adam Grare <[email protected]>
Date:   Wed Nov 21 09:29:25 2018 -0500

    Merge pull request #18220 from borod108/rfe/cluster_upgrade_with_ansible
    
    Upgrade Ovirt Cluster through Ansible
    
    (cherry picked from commit 9f1954a9d945cf1b1a16281adac4716b8bc54aac)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
enhancement hammer/backported providers/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@borod108 @agrare @miq-bot @simaishi @Fryguy