Add owner to orch stack model provisioning #18209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit d-m-u@5621fd7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This comment has been minimized.
This comment has been minimized.
|
@miq-bot add_reviewer @tinaafitz |
kbrock
reviewed
Nov 16, 2018
| @@ -93,6 +97,10 @@ def stdout(format = nil) | |||
| format.nil? ? try(:raw_stdout) : try(:raw_stdout, format) | |||
| end | |||
|
|
|||
| def set_tenant_from_group | |||
There was a problem hiding this comment.
Does the OwnershipMixin already do this for you?
(will this code work if you remove this validation and method?)
The logic behind the scenes for set_tenant_from_group is quite complex. Otherwise we end up running quite a few queries for code that is not altering the group.
There was a problem hiding this comment.
Nope. It won't work if you remove the validation and method.
Also, yeah, they are beautiful tests, aren't they? Stolen directly from you.
tinaafitz
approved these changes
Nov 16, 2018
mkanoor
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add owner to orch stacks so that when we retire them, we can have some concept of who the retiree is. This is exact the same's we do for services.