Remove tenant selection from base deployment options #18202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bzwei unrecognized command 'label', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
d-m-u
approved these changes
Nov 14, 2018
|
Checked commit bzwei@b2c6ef6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@bzwei Looks good. |
|
@mkanoor Please review. |
|
@bzwei if this can be backported, please add the hammer/yes and gaprindashvili/yes labels |
mkanoor
approved these changes
Nov 19, 2018
|
@miq-bot add_label hammer/yes, gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Nov 19, 2018
Remove tenant selection from base deployment options (cherry picked from commit 2ca01f1) https://bugzilla.redhat.com/show_bug.cgi?id=1642594
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 19, 2018
Remove tenant selection from base deployment options (cherry picked from commit 2ca01f1) https://bugzilla.redhat.com/show_bug.cgi?id=1651391
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1642594
The only provider that needs tenant is openstack. The options will be added in manageiq-providers-openstack repo.
Newly generated service dialog from orchestration template by default will no longer contain a dynamic dropdown for tenant selection.
@miq-bot assign @tinaafitz
@miq-bot label bug
cc @d-m-u
This PR will temporarily break the CI build for manageiq-providers-openstack, manageiq-providers-azure, and manageiq-providers-amazon.