Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MiqQueue for enabling/disabling a conversion_host #18191

Merged
merged 5 commits into from
Nov 26, 2018
Merged

Use MiqQueue for enabling/disabling a conversion_host #18191

merged 5 commits into from
Nov 26, 2018

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented Nov 13, 2018 •
edited
Loading

Part of the work for https://bugzilla.redhat.com/show_bug.cgi?id=1628489

This is to allow UI to trigger through API.

Related:

@miq-bot miq-bot added the wip label Nov 13, 2018
@jameswnl jameswnl force-pushed the v2vhost branch 2 times, most recently from cdae2eb to 0285ef2 Compare November 13, 2018 17:00
@djberg96
Copy link
Contributor

@jameswnl Definitely outside the realm of my expertise, so I can't comment too much on the implementation other than to say that I didn't see anything obviously wrong.

As I mentioned on gitter, I would really love comments for every method, even if it seems obvious to you. That way, people like me (or future maintainers) will be able to understand it better. :)

@jameswnl jameswnl force-pushed the v2vhost branch 2 times, most recently from cd50e1a to eb9d997 Compare November 15, 2018 21:38
@djberg96
Copy link
Contributor

I think the trend now is to use double plus allow(your_double) instead of allow_any_instance_of.

@jameswnl jameswnl force-pushed the v2vhost branch 2 times, most recently from 7c868e9 to 2d2ddfc Compare November 15, 2018 23:15
@jameswnl jameswnl changed the title [WIP] enable/disable a conversion_host enable/disable a conversion_host Nov 15, 2018
@jameswnl
Copy link
Contributor Author

@miq-bot remove_label wip
@miq-bot add_labels enhancement, hammer/yes

@jameswnl
Copy link
Contributor Author

@agrare can you take a look?

@agrare agrare self-assigned this Nov 16, 2018
@miq-bot
Copy link
Member

miq-bot commented Nov 16, 2018

Checked commits jameswnl/manageiq@b964ba6~...b85148b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🍪

@jameswnl jameswnl changed the title enable/disable a conversion_host Use MiqQueue for enabling/disabling a conversion_host Nov 16, 2018
@djberg96
Copy link
Contributor

👍

@agrare agrare merged commit d4560c6 into ManageIQ:master Nov 26, 2018
@agrare agrare added this to the Sprint 100 Ending Dec 3, 2018 milestone Nov 26, 2018
@agrare agrare added the v2v label Nov 26, 2018
@jameswnl jameswnl deleted the v2vhost branch November 26, 2018 15:23
@simaishi simaishi mentioned this pull request Nov 26, 2018
Merged
simaishi pushed a commit that referenced this pull request Nov 26, 2018
@agrare @simaishi
Merge pull request #18191 from jameswnl/v2vhost
918f537 
Use MiqQueue for enabling/disabling a conversion_host

(cherry picked from commit d4560c6)

https://bugzilla.redhat.com/show_bug.cgi?id=1628489
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 918f537950d10ee5eb3c63d6464e6b97ef53192a
Author: Adam Grare <[email protected]>
Date:   Mon Nov 26 10:21:08 2018 -0500

    Merge pull request #18191 from jameswnl/v2vhost
    
    Use MiqQueue for enabling/disabling a conversion_host
    
    (cherry picked from commit d4560c61aaf492500404a63d2b756a96bfee9b7c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1628489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@djberg96 djberg96 djberg96 approved these changes

Assignees

@agrare agrare

Labels
enhancement hammer/backported v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jameswnl @djberg96 @miq-bot @simaishi @agrare