Add Conversion Host features #18190
Merged
Add Conversion Host features #18190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djberg96
changed the title
|
@martinpovolny I've nested it under Migrations, and I can see in the database that it's set the product feature parent as expected. |
|
Checked commits https://github.com/djberg96/manageiq/compare/cdcdd7ec4f9f28e94da21f8053f8ca74512a7707~...182ca5c6bdbd7c09cc00ee64ebe5c5108f4c5f6f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
I am going to rebase #18203 on top of this one. And that will be the point where the content of the RBAC tree under roles will be expected to be correct. |
simaishi
pushed a commit
that referenced
this pull request
Nov 15, 2018
Add Conversion Host features (cherry picked from commit 808a114)
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds features for ConversionHosts in order to satisfy ManageIQ/manageiq-api#507 as part of the v2v effort.
Marked as a WIP for now until my fellow v2v compatriots can confirm this is correct.