Don't create retire subtasks for service templates #18184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
|
@miq-bot add_label hammer/yes |
d-m-u
changed the title
d-m-u
force-pushed
the
1608958
branch
2 times, most recently
from
17f25de to
abf744a
Compare
miq-bot
changed the title
|
Checked commit d-m-u@fab614a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label blocker |
tinaafitz
approved these changes
Nov 13, 2018
mkanoor
approved these changes
Nov 14, 2018
simaishi
pushed a commit
that referenced
this pull request
Nov 14, 2018
Don't create retire subtasks for service templates (cherry picked from commit a1ba9b0) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1608958
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1608958
We had taken out much of the logic in the create_retire_subtask method for filtering out things we shouldn't create tasks for as part of a refactor because it didn't belong in the service task creation. In the process, someone was a complete doofus who forgot to override the service_template
retireable?method in theci_feature_mixin.