Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't JSON.parse(nil) #18172

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Don't JSON.parse(nil) #18172

merged 1 commit into from
Nov 12, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Nov 7, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1645555

If the default_value is nil in a multiselect dynamic dropdown, we run into a TypeError (no implicit conversion of nil into String).

@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 7, 2018

@miq-bot add_label bug
@miq-bot add_reviewer @eclarizio
@miq-bot assign @gmcculloug

@miq-bot miq-bot added the bug label Nov 7, 2018
@miq-bot miq-bot requested a review from eclarizio November 7, 2018 18:38
@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 7, 2018

@miq-bot add_reviewer @tinaafitz

@miq-bot miq-bot requested a review from tinaafitz November 7, 2018 18:39
eclarizio
eclarizio suggested changes Nov 7, 2018
View reviewed changes
Copy link
Member

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec please?

Otherwise 👍

@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 9, 2018

@bdunne any chance you could 👀 please for me?

@miq-bot
Copy link
Member

miq-bot commented Nov 12, 2018

Checked commit d-m-u@d588654 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

bdunne
bdunne approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@bdunne bdunne merged commit e6bfa5e into ManageIQ:master Nov 12, 2018
@bdunne bdunne added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 12, 2018
@bdunne bdunne assigned bdunne and unassigned gmcculloug Nov 12, 2018
@d-m-u d-m-u deleted the bz1645555 branch November 12, 2018 19:22
@simaishi
Copy link
Contributor

@d-m-u Can this be hammer/yes and gaprindashvili/yes ?

@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 13, 2018

@miq-bot add_label hammer/yes, gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Nov 13, 2018
@bdunne @simaishi
Merge pull request #18172 from d-m-u/bz1645555
580b553 
Don't JSON.parse(nil)

(cherry picked from commit e6bfa5e)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1645555
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 580b553fdaf3ceeaf199c04d7d30d291998b9fb0
Author: Brandon Dunne <[email protected]>
Date:   Mon Nov 12 14:19:39 2018 -0500

    Merge pull request #18172 from d-m-u/bz1645555
    
    Don't JSON.parse(nil)
    
    (cherry picked from commit e6bfa5ef24e2d9a32559379cb670907d250d7073)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1645555

simaishi pushed a commit that referenced this pull request Nov 13, 2018
@bdunne @simaishi
Merge pull request #18172 from d-m-u/bz1645555
306f39f 
Don't JSON.parse(nil)

(cherry picked from commit e6bfa5e)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649380
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 306f39fd56f4dbe5099542d9c23f8738d181af78
Author: Brandon Dunne <[email protected]>
Date:   Mon Nov 12 14:19:39 2018 -0500

    Merge pull request #18172 from d-m-u/bz1645555
    
    Don't JSON.parse(nil)
    
    (cherry picked from commit e6bfa5ef24e2d9a32559379cb670907d250d7073)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649380

nizaminabeel pushed a commit to nizaminabeel/manageiq that referenced this pull request Dec 11, 2018
@bdunne @nabeel-tariq
Merge pull request ManageIQ#18172 from d-m-u/bz1645555
062ec91 
Don't JSON.parse(nil)

(cherry picked from commit e6bfa5e)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclarizio eclarizio eclarizio requested changes

@bdunne bdunne bdunne approved these changes

@tinaafitz tinaafitz tinaafitz approved these changes

Assignees

@bdunne bdunne

Labels
blocker bug gaprindashvili/backported hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@d-m-u @miq-bot @simaishi @tinaafitz @eclarizio @bdunne @gmcculloug