Add aggregate_memory to container project

[yaacov]

Currently container project is missing aggregate_memory method.

BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1618536

[yaacov]

@agrare @cben please review

[agrare]

@yaacov if you include the AggregationMixin you shouldn't need to call aggregate_memory off of ext_management_system

[yaacov]

@agrare please re-review

[agrare]

Can you also add an aggregate_cpu_speed and aggregate_cpu_total_cores methods? Then you shouldn't need to define the alias on all_host_ids.

[JPrause]

@miq-bot add_label blocker

[JPrause]

@yaacov if this will be able to be backported, can you add the hammer/yes flag.

[miq-bot]

Checked commit yaacov@a97887c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[agrare]

Ran a quick test with the expected changes applied:

VimPerformanceState.where(:resource_type => "ContainerProject").map { |state| [state.resource.name, state.state_data[:total_mem]] }
=> [["bookinfo", 128656], ["customer-logging", 128656], ["inventory-dev", 128656], ["default", 128656], ["istio-system", 128656], ["joev-miq-11", 128656]]

So the total_mem is no longer nil 👍

[agrare]

LGTM, future enhancement would be nice to get away from the hard-coded :host in aggregate_hardware in the mixin and define what assoc to use for the aggregation. For now this looks good though.

[yaacov]

@yaacov if this will be able to be backported, can you add the hammer/yes flag.

@JPrause I do not know this part of the code :-( @agrare, WDYT ?

[agrare]

@JPrause yes it can be backported

[simaishi]

@agrare how about gaprindashvili?

[agrare]

Should be fine for gaprindashvili

[simaishi]

Hammer backport details:

$ git log -1
commit 58788a9dcf7205712837e301bfc57073af45e911
Author: Adam Grare <[email protected]>
Date:   Mon Nov 5 15:18:47 2018 -0500

    Merge pull request #18159 from yaacov/wip-add-aggregate_memory-to-container-project
    
    Add aggregate_memory to container project
    
    (cherry picked from commit edd65ff422b8179622b284a549bfb4afe92168ce)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1618536

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 4136e963cdb36ff49c46429acc0509d801b82f54
Author: Adam Grare <[email protected]>
Date:   Mon Nov 5 15:18:47 2018 -0500

    Merge pull request #18159 from yaacov/wip-add-aggregate_memory-to-container-project
    
    Add aggregate_memory to container project
    
    (cherry picked from commit edd65ff422b8179622b284a549bfb4afe92168ce)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1647056