Credential.manager_ref needs to be an integer for Tower 3.3 #18154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_lables bug, blocker, hammer/yes |
jameswnl
changed the title
|
@jameswnl unrecognized command 'add_lables', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
@jameswnl looks like you have an unrelated commit in here |
bdunne
reviewed
Nov 1, 2018
| @@ -125,6 +125,11 @@ def self.build_credential_options | |||
| end | |||
| end | |||
|
|
|||
| def native_ref | |||
There was a problem hiding this comment.
To make it an interface across the inheritance chain
|
@agrare thanks for spotting that. (must be the unintended left-over from testing Fabien's pr) |
|
@agrare this is ready |
agrare
approved these changes
Nov 1, 2018
simaishi
pushed a commit
that referenced
this pull request
Nov 2, 2018
Credential.manager_ref needs to be an integer for Tower 3.3 (cherry picked from commit 7d7b570) https://bugzilla.redhat.com/show_bug.cgi?id=1640533
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1640533
Related to ManageIQ/manageiq-providers-ansible_tower#134