Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include resource_action type and ID in linked components error message #18152

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Include resource_action type and ID in linked components error message #18152

merged 1 commit into from
Nov 1, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Oct 31, 2018 •
edited
Loading

Will help debug https://bugzilla.redhat.com/show_bug.cgi?id=1644320.

When trying to delete a service dialog, if the dialog has connected components, it can't be deleted but this enhances the error message to tell you if what is still connected to the dialog.

before:
screen shot 2018-10-31 at 4 27 59 pm
after:
screen shot 2018-11-01 at 9 06 00 am

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 31, 2018

@miq-bot add_label bug
@miq-bot assign @gmcculloug
@miq-bot add_reviewer @bdunne

@miq-bot miq-bot added the bug label Oct 31, 2018
@miq-bot miq-bot requested a review from bdunne October 31, 2018 16:16
bdunne
bdunne reviewed Oct 31, 2018
View reviewed changes
app/models/custom_button.rb Outdated Show resolved Hide resolved
@d-m-u d-m-u closed this Oct 31, 2018
@d-m-u d-m-u reopened this Oct 31, 2018
@d-m-u d-m-u changed the title [WIP] Delete resource_action of cb as well Include resource_action type and ID in linked components error message Oct 31, 2018
bdunne
bdunne reviewed Oct 31, 2018
View reviewed changes
app/models/dialog.rb Outdated Show resolved Hide resolved
@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 31, 2018

@miq-bot add_label gaprindashvili/yes, hammer/yes
@miq-bot remove_label bug
@miq-bot add_label enhancement
it's not a bug fix at this point.

@bdunne
Copy link
Member

bdunne commented Oct 31, 2018

Would you mind updating the tests for this?

@gmcculloug
Copy link
Member

It would be really cool if you put an example before/after error message right in the PR description. 🎃 🍬

@gmcculloug
Copy link
Member

While this is a better message it only helps people accessing the console so they can lookup the object. It would be better if we could provide the name of the item along with the data you have here.

It might looks something like this:

CustomButton:20 - Change CPU value, ServiceTemplate:5 - RHEL with Apache

gmcculloug
gmcculloug approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have a good chance at identifying the resource from the UI. Thanks 👍

@gmcculloug gmcculloug merged commit e018bc6 into ManageIQ:master Nov 1, 2018
@gmcculloug gmcculloug added this to the Sprint 98 Ending Nov 5, 2018 milestone Nov 1, 2018
simaishi pushed a commit that referenced this pull request Nov 2, 2018
@gmcculloug @simaishi
Merge pull request #18152 from d-m-u/bz1644320
b8e41be 
Include resource_action type and ID in linked components error message

(cherry picked from commit e018bc6)

https://bugzilla.redhat.com/show_bug.cgi?id=1644320
@simaishi
Copy link
Contributor

simaishi commented Nov 2, 2018

Hammer backport details:

$ git log -1
commit b8e41be8bd6b182d6f629f66a1689e72dabc57f0
Author: Greg McCullough <[email protected]>
Date:   Thu Nov 1 17:31:08 2018 -0400

    Merge pull request #18152 from d-m-u/bz1644320
    
    Include resource_action type and ID in linked components error message
    
    (cherry picked from commit e018bc63c68e5ea08b8ffe2313289ccce3113857)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1644320

@d-m-u d-m-u deleted the bz1644320 branch February 1, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne left review comments

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@gmcculloug gmcculloug

Labels
enhancement hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d-m-u @bdunne @gmcculloug @simaishi @miq-bot