Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't need the name, since it's mixed in... #18117

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Don't need the name, since it's mixed in... #18117

merged 1 commit into from
Oct 22, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Oct 22, 2018 •
edited
Loading

@bdunne @agrare @jrafanie

Thanks for the catch, you all.

I broke master with the merge of #18113, because klass was the wrong thing to be passing and it doesn't actually need to be an argument at all.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1638502

We should be setting the retirement_requester on the object, not just on the request.

related

#18113

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 22, 2018

@kbrock sorry :( this was stupid of me.

@d-m-u d-m-u mentioned this pull request Oct 22, 2018
Merged
@kbrock kbrock added the bug label Oct 22, 2018
@kbrock kbrock self-assigned this Oct 22, 2018
@kbrock kbrock added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 22, 2018
@kbrock kbrock merged commit 1544ad2 into ManageIQ:master Oct 22, 2018
@kbrock
Copy link
Member

kbrock commented Oct 22, 2018 •
edited
Loading

Frustrating. I'm so used to checking for a red build that I didn't register that the tests/CI was not running today :(

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 22, 2018

@miq-bot add_label hammer/yes, bug, blocker, gaprindashvili/yes
but please don't backport, will need to open a whole new PR for gap

simaishi pushed a commit that referenced this pull request Oct 22, 2018
@kbrock @simaishi
Merge pull request #18117 from d-m-u/fixing_red_master
4c11b0d 
Don't need the name, since it's mixed in...

(cherry picked from commit 1544ad2)

https://bugzilla.redhat.com/show_bug.cgi?id=1638502
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 4c11b0d164b08aa881dea893cb0dd7733895b991
Author: Keenan Brock <[email protected]>
Date:   Mon Oct 22 15:43:24 2018 -0400

    Merge pull request #18117 from d-m-u/fixing_red_master
    
    Don't need the name, since it's mixed in...
    
    (cherry picked from commit 1544ad2adc38c985d0af2db283a92f88c0310cde)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1638502

@simaishi
Copy link
Contributor

As per @d-m-u this PR is no longer needed in gaprindashvili branch, removing the label.

@d-m-u d-m-u deleted the fixing_red_master branch February 1, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kbrock kbrock

Labels
blocker bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-m-u @kbrock @simaishi @miq-bot