Add default of admin to requester in make retire request

[d-m-u]

Since the merge of #17951, which adds a system_context for retirement, make_retire_request takes a user.

Brandon thinks make_retire_request should have a default user, and Tina thinks if we must have one, it should be admin. So. Boooya.

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1618530

related:
ManageIQ/manageiq-api#497

[d-m-u]

@miq-bot add_reviewer @bdunne
@miq-bot add_reviewer @tinaafitz
@miq_bot add_label bug, blocker, gaprindashvili/yes, hammer/yes

[miq-bot]

Checked commit d-m-u@244a248 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 4 offenses detected

app/models/mixins/retirement_mixin.rb

• 💣 💥 🔥 🚒 - Line 12, Col 3 - Lint/Syntax - module definition in method body
  (Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
• 💣 💥 🔥 🚒 - Line 13, Col 49 - Lint/Syntax - unexpected token tEQL
  (Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
• 💣 💥 🔥 🚒 - Line 13, Col 83 - Lint/Syntax - unexpected token tRPAREN
  (Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)
• 💣 💥 🔥 🚒 - Line 1, Col 1 - Lint/Syntax - module definition in method body
  (Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)

[bdunne]

Why 'admin' here and User.current_user.userid everywhere else?

[d-m-u]

Because we shouldn't be doing retirement based on current_user, it should be from the evm_owner, and if not one of those, admin. Otherwise the system retirement can run with different users on a retry.

[kbrock]

agreed

    def make_retire_request(*src_ids, requester = User.current_user)

If you want the userid - please use User.current_userid

[d-m-u]

I don't want current_user here at all. The place we use it is from the UI where it makes sense that we want the user who clicked on retirement. It should not be in make_retire_request. We're not using "User.current_user.userid everywhere else", Brandon, that was the point of the changes yesterday.