Retire Task deliver_to_automate now uses tenant_identity #18104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
changed the title
d-m-u
force-pushed
the
fixing_retirement_task_user
branch
from
6496fd5 to
f870703
Compare
d-m-u
changed the title
d-m-u
force-pushed
the
fixing_retirement_task_user
branch
from
f870703 to
9558cd6
Compare
d-m-u
changed the title
kbrock
reviewed
Oct 25, 2018
app/models/miq_retire_task.rb
Outdated
| :miq_group_id => 2, | ||
| :tenant_id => 1, | ||
| :user_id => tenant_identity.id, | ||
| :miq_group_id => tenant_identity.miq_groups.first.id, |
There was a problem hiding this comment.
Suggested change
| :miq_group_id => tenant_identity.miq_groups.first.id, | |
| :miq_group_id => tenant_identity.current_group.id, |
There was a problem hiding this comment.
technically, this could be current_group_id, but you need to download current_group for the next line, so probably close enough
app/models/miq_retire_task.rb
Outdated
| :tenant_id => 1, | ||
| :user_id => tenant_identity.id, | ||
| :miq_group_id => tenant_identity.miq_groups.first.id, | ||
| :tenant_id => tenant_identity.miq_groups.first.tenant.id, |
There was a problem hiding this comment.
Suggested change
| :tenant_id => tenant_identity.miq_groups.first.tenant.id, | |
| :tenant_id => tenant_identity.current_group.tenant_id, |
d-m-u
force-pushed
the
fixing_retirement_task_user
branch
from
9558cd6 to
48c6d5e
Compare
|
@miq-bot remove_label wip |
d-m-u
changed the title
tinaafitz
approved these changes
Oct 25, 2018
d-m-u
force-pushed
the
fixing_retirement_task_user
branch
from
48c6d5e to
567b40d
Compare
d-m-u
force-pushed
the
fixing_retirement_task_user
branch
from
567b40d to
a396837
Compare
|
Checked commit d-m-u@a396837 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
kbrock
changed the title
simaishi
pushed a commit
that referenced
this pull request
Oct 26, 2018
Retire Task deliver_to_automate now uses tenant_identity (cherry picked from commit af80b91) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1640618
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
app/models/miq_retire_task.rbChange hardcoded user reference to the request user and tenant
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1640618