Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse automation attrs correctly #18084

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Parse automation attrs correctly #18084

merged 1 commit into from
Oct 10, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Oct 10, 2018 •
edited
Loading

This should fix the last OrchestrationStack retirement bug as described in https://bugzilla.redhat.com/show_bug.cgi?id=1632239.

When we deliver things to automate they should be in the format {"OrchestrationStack::orchestration_stack"=>1122} rather than {"OrchestrationStack::OrchestrationStack"=>1122}.

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 10, 2018

@miq-bot add_reviewer @tinaafitz
@miq-bot add_reviewer @mkanoor
@miq-bot add_label bug, hammer/yes, gaprindashvili/yes
@miq-bot assign @gmcculloug

@miq-bot miq-bot requested review from tinaafitz and mkanoor October 10, 2018 20:00
d-m-u added a commit to d-m-u/manageiq-automation_engine that referenced this pull request Oct 10, 2018
@d-m-u
Test ManageIQ/manageiq#18084
93658d0
@d-m-u d-m-u mentioned this pull request Oct 10, 2018
Closed
tinaafitz
tinaafitz approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-m-u Looks great!

@mkanoor mkanoor merged commit 3f9ac40 into ManageIQ:master Oct 10, 2018
@mkanoor mkanoor added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 10, 2018
@tinaafitz tinaafitz mentioned this pull request Oct 10, 2018
Closed
simaishi pushed a commit that referenced this pull request Oct 11, 2018
@mkanoor @simaishi
Merge pull request #18084 from d-m-u/call_create_automation_attrs_fro…
f267fb2 
…m_objects_before_deliver_to_automate

Parse automation attrs correctly

(cherry picked from commit 3f9ac40)

https://bugzilla.redhat.com/show_bug.cgi?id=1632239
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit f267fb2da0462f61d2c1f1099bf6716fb00f5a84
Author: Madhu Kanoor <[email protected]>
Date:   Wed Oct 10 16:57:04 2018 -0400

    Merge pull request #18084 from d-m-u/call_create_automation_attrs_from_objects_before_deliver_to_automate
    
    Parse automation attrs correctly
    
    (cherry picked from commit 3f9ac400ae13274af108886cf71bb8decddc3d4c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1632239

@simaishi
Copy link
Contributor

@d-m-u app/models/miq_retire_task.rb doesn't exist in gaprindashvili branch. Let me know what to do here...

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 11, 2018

Sorry, I messed up. This is g/no.

@d-m-u
Copy link
Contributor Author

d-m-u commented Oct 11, 2018

@miq-bot add_label gaprindashvili/no
@miq-bot remove_label gaprindashvili/yes

@d-m-u d-m-u deleted the call_create_automation_attrs_from_objects_before_deliver_to_automate branch February 1, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor mkanoor approved these changes

@tinaafitz tinaafitz tinaafitz approved these changes

Assignees

@gmcculloug gmcculloug

Labels
blocker bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@d-m-u @simaishi @tinaafitz @mkanoor @gmcculloug @miq-bot