Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use interpolation in gettext strings #18067

Merged

Conversation

mzazrivec
Copy link
Contributor

Fixes the following CI failure:

 1) placeholders gettext strings do not contain interpolations
     Failure/Error: expect(errors).to be_empty
       expected `["\"Cancel operation is not supported for \#{self.class.name}\""].empty?` to return true, got false
     Shared Example Group: :placeholders called from ./spec/i18n/placeholders_spec.rb:2
     # ./spec/shared/i18n/placeholders.rb:49:in `block (2 levels) in <top (required)>'

@miq-bot add_label internationalization, hammer/yes

@carbonin carbonin self-assigned this Oct 8, 2018
@carbonin carbonin merged commit 1db6992 into ManageIQ:master Oct 8, 2018
@carbonin carbonin added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 8, 2018
@mzazrivec mzazrivec deleted the dont_use_interpolations_in_gettext branch October 8, 2018 13:19
@mzazrivec
Copy link
Contributor Author

@simaishi Could you please cherry-pick this one into hammer so that I can rebase #18040 ? Thanks.

simaishi pushed a commit that referenced this pull request Oct 8, 2018
…ettext

Don't use interpolation in gettext strings

(cherry picked from commit 1db6992)
@simaishi
Copy link
Contributor

simaishi commented Oct 8, 2018

Hammer backport details:

$ git log -1
commit 5981f28e81c13525e14fbb03311d8b1537645017
Author: Nick Carboni <[email protected]>
Date:   Mon Oct 8 09:06:00 2018 -0400

    Merge pull request #18067 from mzazrivec/dont_use_interpolations_in_gettext
    
    Don't use interpolation in gettext strings
    
    (cherry picked from commit 1db6992b5076a99e13623c3de8df5030077ab341)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants