Normalize extra_vars support for Ansible Tower playbooks.

[lfu]

• Refactor the support of extra_vars for ServiceAnsiblePalybook and automate playbook method.
• Add extra_vars support for ServiceAnsibleTower.

Includes ManageIQ/manageiq-automation_engine#244

Fixes #18005.

@miq-bot assign @gmcculloug
@miq-bot add_label enhancement, services

cc @mkanoor

[gmcculloug]

@lfu @mkanoor Should these changes be linked to https://bugzilla.redhat.com/show_bug.cgi?id=1611946

Can we solve the automate_workspace issue from that ticket (see https://bugzilla.redhat.com/show_bug.cgi?id=1611946#c16) with these changes?

[syncrou]

@lfu - Regarding @gmcculloug's comment it seems there would need to be the addition of the automate_workspace key in the manageiq_connection hash to solve that issue.

[mkanoor]

@lfu should this file name indicate that its ExtraVars maybe ApiExtraVars. Since most of the fields in there are going in as ExtraVars for connecting to our REST API.

[lfu]

I'm not good at naming. But I think ApiAnsibleMixin makes more sense than ApiExtraVarsMixin in terms of audience. People may have heard of ansible but not extra_vars.

@gmcculloug Ideas?

[gmcculloug]

Not sure if I'm helping here, but I came up with: AnsibleCallbackExtraVarsMixin

[lfu]

Renamed the module to AnsibleExtraVarsMixin.

[lfu]

@gmcculloug @syncrou Regarding ServiceAnsiblePalybook, this PR only refactor the existing code for extra_vars which won't fix the issue in https://bugzilla.redhat.com/show_bug.cgi?id=1611946.

[lfu]

Tested with Ansible Tower Service, Ansible Playbook Service and automate playbook method. manageiq_env and manageiq_connection_env hashes were added into playbooks' extra_vars.

[mkanoor]

@lfu If you have examples in your playbook repo can you post the link here.
It might make sense to put them in a different directory since it can be shared across

• Ansible Tower Service
• Ansible Playbook Service
• Ansible Playbook Method

[lfu]

The playbook I used for testing is this one.

[miq-bot]

Checked commits lfu/manageiq@b9ccc09~...3b6fa05 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 2 offenses detected

app/models/service_ansible_playbook.rb

• ❗ - Line 76, Col 6 - Layout/MultilineMethodCallIndentation - Use 2 (not 1) spaces for indenting an expression spanning multiple lines.

app/models/service_ansible_tower.rb

• ❗ - Line 79, Col 6 - Layout/MultilineMethodCallIndentation - Use 2 (not 1) spaces for indenting an expression spanning multiple lines.