Fix ordering in list of custom buttons #18049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label hammer/yes, gaprindashvili/yes |
bdunne
reviewed
Oct 2, 2018
|
|
||
| before do | ||
| [custom_button_3, custom_button_4].each { |x| custom_button_set.add_member(x) } | ||
| end | ||
|
|
||
| it 'returns filtered array of CustomButtonSet and CustomButtons' do |
There was a problem hiding this comment.
Maybe add "ordered by name" to the test description so that we remember in the future?
lpichler
force-pushed
the
fix_ordering_in_custom_buttons
branch
from
a3976a9 to
ef68e4a
Compare
|
Checked commit lpichler@ef68e4a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Oct 2, 2018
gtanzillo
approved these changes
Oct 2, 2018
simaishi
pushed a commit
that referenced
this pull request
Oct 3, 2018
Fix ordering in list of custom buttons (cherry picked from commit 6a9fc2a) https://bugzilla.redhat.com/show_bug.cgi?id=1628737
|
Hammer backport details: |
|
@lpichler this fix does not seems to be returning list of Custom Buttons in button order they were saved in, this is returning them sorted by name. Order of custom buttons should be based upon what is stored in :button_order key in set_data column for CustomButonSet record |
|
@h-kataria I will create fix, thanks! |
simaishi
pushed a commit
that referenced
this pull request
Nov 5, 2018
Fix ordering in list of custom buttons (cherry picked from commit 6a9fc2a) https://bugzilla.redhat.com/show_bug.cgi?id=1635759
|
Gaprindashvili backport details: |
nizaminabeel
pushed a commit
to nizaminabeel/manageiq
that referenced
this pull request
Dec 11, 2018
…m_buttons Fix ordering in list of custom buttons (cherry picked from commit 6a9fc2a) https://bugzilla.redhat.com/show_bug.cgi?id=1635759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
@miq-bot assign @gtanzillo
thanks @h-kataria !