Add OSP attributes to VM ServiceResource options #18045
Conversation
|
@AparnaKarve Cannot apply the following label because they are not recognized: hammer |
|
@AparnaKarve unrecognized command 'add_assignee', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
@miq-bot add_label hammer/yes |
|
@AparnaKarve unrecognized command 'add_assignee', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
| @@ -30,6 +30,8 @@ def validate_config_info(options) | |||
| vm_options = {} | |||
| vm_options[:pre_ansible_playbook_service_template_id] = pre_service_id if vm_hash[:pre_service] | |||
| vm_options[:post_ansible_playbook_service_template_id] = post_service_id if vm_hash[:post_service] | |||
| vm_options[:osp_security_group_id] = vm_hash[:osp_security_group] if vm_hash[:osp_security_group].present? | |||
There was a problem hiding this comment.
The backend accepts either vm_hash[:osp_security_group] as an object or vm_hash[:osp_security_group_id] as an id. You can convert them all to ids and save in vm_options[:osp_security_group_id].
Please look at line 25 and 27 as an example. Either vm_hash[:vm_id] or vm_hash[:vm] is accepted.
Same for osp_flavor_id.
There was a problem hiding this comment.
The actions hash coming from the frontend looks like this -
"actions": [
{
"vm_id": "20000000000057",
"pre_service": false,
"post_service": false,
"osp_security_group": "20000000000007",
"osp_flavor": "20000000000001"
}
]
So the security_group and flavor info is available here in terms of id and not object.
On the frontend, we should perhaps change the osp_ keys in the actions hash to be osp_security_group_id and osp_flavor_id, just to be consistent with the naming convention.
There was a problem hiding this comment.
In your example, yes, please change the frontend to use group and flavor ids.
Although v2v frontend never sends actual object, our backend for all service templates always accept both object and ids.
There was a problem hiding this comment.
Thanks -- I made the necessary naming adjustment in ManageIQ/manageiq-v2v#680, and also changed to vm_hash[:osp_security_group_id] and vm_hash[:osp_flavor_id] in this PR
AparnaKarve
force-pushed
the
add_osp_attributes_to_service_resource_options
branch
from
63491d0 to
70d0045
Compare
AparnaKarve
force-pushed
the
add_osp_attributes_to_service_resource_options
branch
from
70d0045 to
856479d
Compare
|
Checked commits AparnaKarve/manageiq@2d2e350~...856479d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@bzwei Anything else to address here? |
…ice_resource_options Add OSP attributes to VM ServiceResource options (cherry picked from commit 532970f)
|
Hammer backport details: |
Adds OSP attributes -
osp_security_group_idandosp_flavor_idto VM ServiceResource options hash.