Adding ansible tags option through cmdline #18030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EsdrasVP
changed the title
EsdrasVP
force-pushed
the
enable_ansible_runner_tags
branch
3 times, most recently
from
5749fa5 to
561149f
Compare
EsdrasVP
changed the title
EsdrasVP
force-pushed
the
enable_ansible_runner_tags
branch
from
561149f to
0c3ebb4
Compare
EsdrasVP
force-pushed
the
enable_ansible_runner_tags
branch
from
0c3ebb4 to
c668107
Compare
agrare
reviewed
Oct 1, 2018
lib/ansible/runner.rb
Outdated
| errors = [] | ||
|
|
||
| errors << "env_vars must be a Hash, got: #{hash.class}" unless env_vars.kind_of?(Hash) | ||
| errors << "extra_vars must be a Hash, got: #{hash.class}" unless extra_vars.kind_of?(Hash) | ||
| errors << "tags must be a String, got: #{String}" if tags.present? && !tags.kind_of?(String) |
There was a problem hiding this comment.
got: #{String}"
Pretty sure you mean got: #{tag.class} here
There was a problem hiding this comment.
@agrare Oh, sorry for that, changed it here for tag.class.
EsdrasVP
force-pushed
the
enable_ansible_runner_tags
branch
from
c668107 to
9a40012
Compare
|
Checked commit EsdrasVP@9a40012 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is able to:
cmdline