Properly create tenant default group for population #18025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a tenant, if there are already groups in the database, it would assign a random group. This would manifest by having a seemingly random group assigned to newly discovered VMs/Hosts. There can then be privilege issues as the admins possibly don't have access to the group. This only happens for customers who had a database before tenancy was introduced in 2015. It incorrectly assigned during the migration process in 20151021174140_assign_tenant_default_group The fix: it will now only assign a tenant group. https://bugzilla.redhat.com/show_bug.cgi?id=1625788 I'm also adding a migration to automatically fix customer's databases Since the issue was introduced in a migration in the first place.
kbrock
changed the title
|
Checked commit kbrock@bea02fc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
changed the title
simaishi
pushed a commit
that referenced
this pull request
Oct 1, 2018
Properly create tenant default group for population (cherry picked from commit 88c3637) https://bugzilla.redhat.com/show_bug.cgi?id=1625788
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a tenant, if there are already groups in the database,
it would assign a random group.
This can only happen for customers who had a database before tenancy
was introduced in 2015
The fix: it will now only assign a tenant group.
https://bugzilla.redhat.com/show_bug.cgi?id=1625788
I'm also adding a migration to automatically fix customer's databases