Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rescue NoMethodError to prevent requeueing something that won't work #18017

Merged
merged 2 commits into from
Sep 25, 2018
Merged

Rescue NoMethodError to prevent requeueing something that won't work #18017

merged 2 commits into from
Sep 25, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Sep 25, 2018

@bdunne bdunne added the bug label Sep 25, 2018
@bdunne bdunne force-pushed the invoke_api_task_no_method branch from 0abae89 to 7d61e01 Compare September 25, 2018 18:45
@bdunne bdunne requested a review from carbonin September 25, 2018 18:46
@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2018

Checked commits bdunne/manageiq@0af8deb~...7d61e01 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@carbonin carbonin self-assigned this Sep 25, 2018
carbonin
carbonin approved these changes Sep 25, 2018
View reviewed changes
Copy link
Member

@carbonin carbonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@carbonin carbonin merged commit 150b6ef into ManageIQ:master Sep 25, 2018
@carbonin carbonin added this to the Sprint 96 Ending Oct 8, 2018 milestone Sep 25, 2018
@bdunne bdunne deleted the invoke_api_task_no_method branch September 25, 2018 22:04
simaishi pushed a commit that referenced this pull request Sep 26, 2018
@carbonin @simaishi
Merge pull request #18017 from bdunne/invoke_api_task_no_method
6ce2c45 
Rescue NoMethodError to prevent requeueing something that won't work

(cherry picked from commit 150b6ef)

https://bugzilla.redhat.com/show_bug.cgi?id=1632844
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 6ce2c45829616fef1ee2734655a3df42e1ef2bed
Author: Nick Carboni <[email protected]>
Date:   Tue Sep 25 17:56:16 2018 -0400

    Merge pull request #18017 from bdunne/invoke_api_task_no_method
    
    Rescue NoMethodError to prevent requeueing something that won't work
    
    (cherry picked from commit 150b6ef427c9e7c28b227d96274ae892afa7025a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1632844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonin carbonin carbonin approved these changes

Assignees

@carbonin carbonin

Labels
bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdunne @miq-bot @simaishi @carbonin