Get container statuses during refresh #18016
Conversation
|
@agrare do you know who could review this? |
app/models/host.rb
Outdated
| containers = MiqLinux::Utils.parse_docker_ps_list(containers) | ||
| end | ||
|
|
||
| (services + containers).each do |service| |
There was a problem hiding this comment.
Are docker containers the same thing as services? This might be true for this specific openstack case but I doubt it is true universally for all host types.
IMO if openstack is returning some services as systemd units and some as docker containers this should be in the openstack host model.
We can split out a method here called collect_services which in openstack you could do basically super.concat(docker_services)
alexander-demicev
force-pushed
the
containerized-services
branch
from
8b9d26d to
493d0ab
Compare
|
@agrare Hi, is it better now? :) |
app/models/host.rb
Outdated
| @@ -1091,7 +1091,7 @@ def refresh_patches(ssu) | |||
| Patch.refresh_patches(self, patches) | |||
| end | |||
|
|
|||
| def refresh_services(ssu) | |||
| def collect_services(ssu) | |||
| xml = MiqXml.createDoc(:miq).root.add_element(:services) | |||
There was a problem hiding this comment.
I think this should be in the refresh_services method not in here
alexander-demicev
force-pushed
the
containerized-services
branch
from
493d0ab to
ad7fb6f
Compare
|
Checked commit alexander-demicev@ad7fb6f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Get container statuses during refresh of host. We need this if openstack was deployed with containerized services. I decided to keep attributes like 'systemd_load' for containers because they are used for scopes which are passed to UI.
https://bugzilla.redhat.com/show_bug.cgi?id=1573507