Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from apache module mod_auth_kerb to mod_auth_gssapi #18014

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

jvlcek
Copy link
Member

@jvlcek jvlcek commented Sep 24, 2018

https://www.pivotaltracker.com/n/projects/1610127/stories/160659028

This PR is one of a set that will implement moving external authentication support from
the Apache module mod_auth_kerb to mod_auth_gssapi

Once all of the PRs are available I will remove the WIP flag

I also fixed the heredoc delimiters that rubocop did not like.

@jvlcek
Copy link
Member Author

jvlcek commented Sep 24, 2018

@miq-bot add_label wip

@jvlcek
Copy link
Member Author

jvlcek commented Sep 24, 2018

@miq-bot add_label enhancement

@jvlcek
Copy link
Member Author

jvlcek commented Sep 24, 2018

@jvlcek
Copy link
Member Author

jvlcek commented Sep 24, 2018

@miq-bot remove_label wip
@miq-bot assign @abellotti

@jvlcek jvlcek changed the title [WIP] Move from apache module mod_auth_kerb to mod_auth_gssapi Move from apache module mod_auth_kerb to mod_auth_gssapi Sep 24, 2018
@miq-bot miq-bot removed the wip label Sep 24, 2018
@jvlcek
Copy link
Member Author

jvlcek commented Sep 25, 2018

@miq-bot add_label hammer/yes

@jvlcek
Copy link
Member Author

jvlcek commented Oct 3, 2018

@gtanzillo and @abellotti I have made the update necessary to address the issue @abellotti raised when we met yesterday regarding yup update support to handle both the old, mod_auth_kerb and new mod_auth_gssapi config file syntax. This should be good to go now.

Thank you! JoeV

@miq-bot
Copy link
Member

miq-bot commented Oct 3, 2018

Checked commit jvlcek@21e5bcf with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@jvlcek
Copy link
Member Author

jvlcek commented Oct 5, 2018

https://bugzilla.redhat.com/show_bug.cgi?id=1636547 will be used to track this work.

@gtanzillo gtanzillo added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 5, 2018
@gtanzillo gtanzillo merged commit 90853a6 into ManageIQ:master Oct 5, 2018
simaishi pushed a commit that referenced this pull request Oct 8, 2018
Move from apache module mod_auth_kerb to mod_auth_gssapi

(cherry picked from commit 90853a6)

https://bugzilla.redhat.com/show_bug.cgi?id=1636547
@simaishi
Copy link
Contributor

simaishi commented Oct 8, 2018

Hammer backport details:

$ git log -1
commit 51b26b7a2917fa7707c8efb7e93589b6769b9814
Author: Gregg Tanzillo <[email protected]>
Date:   Fri Oct 5 16:42:46 2018 -0400

    Merge pull request #18014 from jvlcek/gssapi
    
    Move from apache module mod_auth_kerb to mod_auth_gssapi
    
    (cherry picked from commit 90853a61ff9881fb730bdbc71418286b159a0513)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1636547

@jvlcek jvlcek deleted the gssapi branch January 24, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants