Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend-initiated notifications in v2v for Successful and Failed Requests #18012

Merged
merged 2 commits into from
Oct 24, 2018
Merged

Backend-initiated notifications in v2v for Successful and Failed Requests #18012

merged 2 commits into from
Oct 24, 2018

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Sep 21, 2018 •
edited
Loading

This was referenced Sep 21, 2018
Closed
Merged
@AparnaKarve AparnaKarve force-pushed the backend_notifications_for_v2v_requests branch from 1006ba4 to 70f33e1 Compare October 2, 2018 19:37
@miq-bot
Copy link
Member

miq-bot commented Oct 2, 2018

Checked commits AparnaKarve/manageiq@ec2e45f~...70f33e1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@AparnaKarve
Copy link
Contributor Author

@gmcculloug Would you be able to review/merge this?

@AparnaKarve
Copy link
Contributor Author

@miq-bot add_label hammer/yes

@miq-bot add_label transformation

@blomquisg
Copy link
Member

This looks right to me. @h-kataria can you verify the notification changes in this?

@h-kataria
Copy link
Contributor

@blomquisg looks good to me.

@roliveri roliveri merged commit 14bdeb9 into ManageIQ:master Oct 24, 2018
@roliveri roliveri added this to the Sprint 98 Ending Nov 5, 2018 milestone Oct 24, 2018
@AparnaKarve AparnaKarve deleted the backend_notifications_for_v2v_requests branch October 24, 2018 15:53
simaishi pushed a commit that referenced this pull request Oct 25, 2018
@roliveri @simaishi
Merge pull request #18012 from AparnaKarve/backend_notifications_for_…
e31ddae 
…v2v_requests

Backend-initiated notifications in v2v for Successful and Failed Requests

(cherry picked from commit 14bdeb9)

https://bugzilla.redhat.com/show_bug.cgi?id=1642573
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit e31ddae7a87107cc0b5330c53699934db6cd5399
Author: Richard Oliveri <[email protected]>
Date:   Wed Oct 24 11:46:35 2018 -0400

    Merge pull request #18012 from AparnaKarve/backend_notifications_for_v2v_requests
    
    Backend-initiated notifications in v2v for Successful and Failed Requests
    
    (cherry picked from commit 14bdeb9bec2c6f16ce8261e470114019a558b9a8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1642573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hammer/backported v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AparnaKarve @miq-bot @blomquisg @h-kataria @simaishi @roliveri