Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :cinder_volume_types to SupportsFeatureMixin #18000

Merged

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Sep 19, 2018

Also adds "supports_cinder_volume_types" virtual column to ExtManagementSystem to accomodate accessing that field from the API.

Supports ManageIQ/manageiq-ui-classic#4536, which needs to be able to determine feature support via the API.

Also adds "supports_cinder_volume_types" virtual column
to ExtManagementSystem to accomodate accessing that
field from the API.
@miq-bot
Copy link
Member

miq-bot commented Sep 19, 2018

Checked commit mansam@0a3094b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agrare agrare self-assigned this Sep 24, 2018
@agrare
Copy link
Member

agrare commented Sep 24, 2018

This says the travis build is still in progress but https://travis-ci.org/ManageIQ/manageiq/builds/430703492?utm_source=github_status&utm_medium=notification is green, merging.

@agrare agrare merged commit 0f55ac5 into ManageIQ:master Sep 24, 2018
@agrare agrare added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants