Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove line from metering_container_image_spec and FIX CI failure #17974

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Sep 11, 2018

Fixes CI failure
https://travis-ci.org/ManageIQ/manageiq/jobs/426890608#L1472
after removals in #17934 and #17962

the line was adding dynamically column metering_used_cost to class MeteringContainerImage as descendant of Chargeback.

and this column has been returned by

let(:columns) { Chargeback.descendants.collect(&:virtual_attributes_to_define).inject({}, &:merge) }

a we don't have defined formatter currency_precision_2 for this columnmetering_used_cost.

Please merge if any other unrelated sporadic failure will occur.

@miq-bot assign @gtanzillo
@miq-bot add_label bug/sporadic test failure, chargeback

error from travis:

Failures:
  1) MiqReport::Formats.default_format_for_path for chargebacks works
Failure/Error: expect(subj).to eq(:currency_precision_2)
  expected: :currency_precision_2
       got: :general_number_precision_2
  (compared using ==)
  Diff:
@@ -1,2 +1,2 @@
-:currency_precision_2
+:general_number_precision_2
# ./spec/models/miq_report/formats_spec.rb:34:in `block (5 levels) in <top (required)>'
# ./spec/models/miq_report/formats_spec.rb:30:in `each'
# ./spec/models/miq_report/formats_spec.rb:30:in `block (4 levels) in <top (required)>'
Finished in 10 minutes 27 seconds (files took 17.55 seconds to load)
5106 examples, 1 failure, 4 pending

Links

@miq-bot
Copy link
Member

miq-bot commented Sep 11, 2018

Checked commit lpichler@e5c3947 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@gtanzillo gtanzillo added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 11, 2018
@gtanzillo gtanzillo merged commit e5b804e into ManageIQ:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants