-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Canisters save inventory #17966
Fix Canisters save inventory #17966
Conversation
@EsdrasVP you really need to test these end to end before putting these in. |
@agrare You're right, I'm creating some tests to assure this is working. |
e85b361
to
381618b
Compare
Request related to RFE https://bugzilla.redhat.com/show_bug.cgi?id=1629900 |
save_inventory_single(:canister, physical_storage, hash) | ||
def save_canisters_inventory(physical_storage, hashes, target = nil) | ||
return if hashes.nil? | ||
deletes = target == physical_storage ? :use_association : [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as the physical_disks one, this should just be :use_association
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agrare Also changed it.
381618b
to
99d1abb
Compare
This pull request is not mergeable. Please rebase and repush. |
@EsdrasVP you need to rebase not merge upstream into your branch, do |
24dde78
to
2dc8d1c
Compare
Checked commit EsdrasVP@2dc8d1c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This PR is able to: