Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Canisters save inventory #17966

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

EsdrasVP
Copy link
Member

This PR is able to:

  • Fix the save inventory for Canisters to use multi instead of single

@EsdrasVP
Copy link
Member Author

@miq-bot assign @agrare

@agrare
Copy link
Member

agrare commented Sep 11, 2018

@EsdrasVP you really need to test these end to end before putting these in.
When you have a PR to schema, core, and -lenovo you should be able to pass the new specs in your -lenovo repo before taking the core PR out of wip. Without a system to test this on it is more difficult for us to test these core PRs beyond just a visual once-over.

@EsdrasVP EsdrasVP changed the title Fix Canisters save inventory [WIP] Fix Canisters save inventory Sep 11, 2018
@miq-bot miq-bot added the wip label Sep 11, 2018
@EsdrasVP
Copy link
Member Author

@agrare You're right, I'm creating some tests to assure this is working.

@EsdrasVP EsdrasVP force-pushed the fix_save_canisters_inventory branch from e85b361 to 381618b Compare September 11, 2018 14:16
@agrare agrare closed this Sep 13, 2018
@agrare agrare reopened this Sep 13, 2018
@rodneyhbrown7
Copy link

Request related to RFE https://bugzilla.redhat.com/show_bug.cgi?id=1629900

save_inventory_single(:canister, physical_storage, hash)
def save_canisters_inventory(physical_storage, hashes, target = nil)
return if hashes.nil?
deletes = target == physical_storage ? :use_association : []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as the physical_disks one, this should just be :use_association

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrare Also changed it.

@EsdrasVP EsdrasVP changed the title [WIP] Fix Canisters save inventory Fix Canisters save inventory Sep 18, 2018
@miq-bot miq-bot removed the wip label Sep 18, 2018
@EsdrasVP EsdrasVP force-pushed the fix_save_canisters_inventory branch from 381618b to 99d1abb Compare September 18, 2018 19:41
@miq-bot
Copy link
Member

miq-bot commented Sep 18, 2018

This pull request is not mergeable. Please rebase and repush.

@agrare
Copy link
Member

agrare commented Sep 18, 2018

@EsdrasVP you need to rebase not merge upstream into your branch, do git pull --rebase=true upstream master instead

@EsdrasVP EsdrasVP force-pushed the fix_save_canisters_inventory branch from 24dde78 to 2dc8d1c Compare September 19, 2018 11:44
@miq-bot
Copy link
Member

miq-bot commented Sep 19, 2018

Checked commit EsdrasVP@2dc8d1c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@EsdrasVP
Copy link
Member Author

@EsdrasVP you need to rebase not merge upstream into your branch, do git pull --rebase=true upstream master instead

@agrare Sorry for that, in a hurry I used the GitHub editor from my smartphone. Now I rebased here on my machine and I think everything is fine.

@agrare agrare merged commit 6ca6398 into ManageIQ:master Sep 19, 2018
@agrare agrare added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants