Add replication set-up methods to be queued on UI side #17956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
yrudman
force-pushed
the
queue-pglogical-replication-setup
branch
4 times, most recently
from
d2955c2 to
db57156
Compare
yrudman
force-pushed
the
queue-pglogical-replication-setup
branch
from
98395cb to
16bc242
Compare
|
This pull request is not mergeable. Please rebase and repush. |
yrudman
force-pushed
the
queue-pglogical-replication-setup
branch
from
16bc242 to
59ac0a2
Compare
yrudman
force-pushed
the
queue-pglogical-replication-setup
branch
3 times, most recently
from
e820150 to
e3a7da4
Compare
yrudman
changed the title
|
@carbonin could you review |
carbonin
reviewed
Sep 12, 2018
… when corresponding task executed
yrudman
force-pushed
the
queue-pglogical-replication-setup
branch
from
4303fd1 to
40672f4
Compare
carbonin
reviewed
Sep 12, 2018
yrudman
force-pushed
the
queue-pglogical-replication-setup
branch
3 times, most recently
from
e50b801 to
7b6b2f5
Compare
yrudman
force-pushed
the
queue-pglogical-replication-setup
branch
from
7b6b2f5 to
0cfba4c
Compare
|
Checked commits yrudman/manageiq@e7c0712~...0cfba4c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Holding off on assigning the Gaprindashvili label for now until I can get feedback from @dmetzger57 in the BZ. |
|
Merging while red because of known sporadic spec failures which are only present in one version of ruby tested in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add replication set-up methods to be queued on UI side
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1562956
Corresponding PR on UI side: ManageIQ/manageiq-ui-classic#4628
@miq-bot add-label core