Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not duplicate same notification if user belongs to several groups #17918

Merged

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Aug 28, 2018

Issue: When receiver of Notification is tenant and some user belongs to several group than that user receive the same notification multiple times (for each group user belongs to)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1549898

@miq-bot add-label bug, core

@yrudman yrudman force-pushed the do-not-duplicate-same-notification branch from 535ebbf to cfede26 Compare August 28, 2018 16:30
@yrudman yrudman force-pushed the do-not-duplicate-same-notification branch from 582847e to 0bb7a68 Compare August 28, 2018 16:32
@yrudman yrudman force-pushed the do-not-duplicate-same-notification branch from 0bb7a68 to 7312c3a Compare August 28, 2018 17:04
@miq-bot
Copy link
Member

miq-bot commented Aug 28, 2018

Checked commits yrudman/manageiq@af75cbc~...7312c3a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

@yrudman yrudman closed this Aug 29, 2018
@yrudman yrudman reopened this Aug 29, 2018
@gtanzillo gtanzillo self-assigned this Sep 5, 2018
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo modified the milestones: Roadmap, Sprint 94 Ending Sept 10, 2018 Sep 5, 2018
@gtanzillo gtanzillo merged commit 26bf79c into ManageIQ:master Sep 5, 2018
@yrudman yrudman deleted the do-not-duplicate-same-notification branch September 6, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants