Association default can't be array #17915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Association default can't be array, it must be nil, so we take :arel instead.
Ladas
force-pushed
the
association_default_cannot_be_array
branch
from
b9ed0b8 to
41c31ec
Compare
|
@Ladas if this needs to be backported we'll need a BZ |
|
Checked commit Ladas@41c31ec with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@Ladas I don't need it in GA, this is for Hammer. |
miha-plesko
approved these changes
Aug 28, 2018
There was a problem hiding this comment.
I can confirm this works for me. We need it for ManageIQ/manageiq-providers-nuage#131 which is going to be implemented through ManageIQ/manageiq-providers-nuage#138
agrare
approved these changes
Aug 28, 2018
|
BZ that this PR was originally needed for https://bugzilla.redhat.com/show_bug.cgi?id=1619544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Association default can't be array, it must be nil, so we take
:arel instead.