Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InventoryCollection's Builder exception message #17904

Merged
merged 1 commit into from
Sep 5, 2018
Merged

InventoryCollection's Builder exception message #17904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/manageiq/providers/inventory/persister/builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def construct_data
# Creates InventoryCollection
def to_inventory_collection
if @properties[:model_class].nil? && !@options[:without_model_class]
raise MissingModelClassError
raise MissingModelClassError, "Missing model_class for :#{@name} (\"#{@name.to_s.classify}\" or subclass expected)."
end

::ManagerRefresh::InventoryCollection.new(to_hash)
Expand Down
2 changes: 1 addition & 1 deletion spec/models/manageiq/providers/inventory/persister/builder_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def create_persister
it 'throws exception if model_class not specified' do
builder = cloud.prepare_data(:non_existing_ic, persister_class)

expect { builder.to_inventory_collection }.to raise_error(::ManageIQ::Providers::Inventory::Persister::Builder::MissingModelClassError)
expect { builder.to_inventory_collection }.to raise_error(::ManageIQ::Providers::Inventory::Persister::Builder::MissingModelClassError, /NonExistingIc/)
end

# --- adv. settings (TODO: link to gui)---
Expand Down