Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the IC::Builder to Inventory::Persister #17901

Merged
merged 2 commits into from
Aug 24, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 24, 2018

Move the InventoryCollection::Builder to the Inventory::Persister class so that the InventoryCollection class can be extracted.

The high level plan is to move the manageiq specifics out of ManagerRefresh and under ManageIQ::Providers so that the core of ManagerRefresh can be extracted to a gem.

  1. Move app/models/manager_refresh/inventory_collection/builder* -> app/models/manager_refresh/inventory/persister/
  2. Move app/models/manager_refresh/inventory* -> app/models/manageiq/providers/
  3. Update references to ManagerRefresh::Inventory to ManageIQ::Providers::Inventory

parse.inventory_collections
end
end
class ManagerRefresh::Inventory < ManageIQ::Providers::Inventory
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this as a placeholder so that we can merge this green and move the rest of the provider plugins over, then we can delete this once they're all updated, rather than having to do a mass merge red.

@agrare agrare force-pushed the move_inventory_collection_builder branch from f534228 to be96102 Compare August 24, 2018 18:32
@agrare agrare force-pushed the move_inventory_collection_builder branch from be96102 to 050072c Compare August 24, 2018 18:47
@miq-bot
Copy link
Member

miq-bot commented Aug 24, 2018

Checked commits agrare/manageiq@e35091d~...050072c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
14 files checked, 5 offenses detected

app/models/manager_refresh/inventory/persister/builder/cloud_manager.rb

app/models/manager_refresh/inventory/persister/builder/container_manager.rb

app/models/manager_refresh/inventory/persister/builder/infra_manager.rb

app/models/manager_refresh/inventory/persister/builder/shared.rb

@gtanzillo gtanzillo added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 24, 2018
@gtanzillo gtanzillo merged commit e315a78 into ManageIQ:master Aug 24, 2018
@agrare agrare deleted the move_inventory_collection_builder branch August 24, 2018 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants