Effective delete complement #17882
Closed
Effective delete complement #17882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
force-pushed
the
effective_delete_complement
branch
from
9c16b6c to
a3b9fa4
Compare
|
This pull request is not mergeable. Please rebase and repush. |
Add efficient delete_complement, that easily works for hundreds of thousands records involved
Ladas
force-pushed
the
effective_delete_complement
branch
from
a3b9fa4 to
cd76c80
Compare
|
Checked commit Ladas@cd76c80 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This pull request is not mergeable. Please rebase and repush. |
|
This code has moved to the inventory_refresh gem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete complement that works effectively even if we are passing hundreds of thousands of uuids
Depends on:
Specs and detailed benchmarks will be added in followups. So far testing on deleting 50k rows out of 100k and the query to fetch the records is very quick.