Updating example oVirt cloud-init template #17869
Conversation
jan-zmeskal
force-pushed
the
updated_ovirt_ci_template
branch
from
1049b4c to
32f7445
Compare
jan-zmeskal
changed the title
|
Checked commit jan-zmeskal@32f7445 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
| - nmcli connection modify eth0 | ||
| - ETH_CON=$(nmcli --get-values name connection show | grep "eth") | ||
| - nmcli connection down "$ETH_CON" | ||
| - nmcli connection modify "$ETH_CON" | ||
| ip4 <%= evm[:ip_addr] %>/<%= evm[:subnet_mask] %> |
There was a problem hiding this comment.
Do we want to avoid setting the rest of these ip4 attributes if it's marked as dhcp?
There was a problem hiding this comment.
@bdunne I also thought about this but I am not sure. Because you might want to assign static IP to to a VM and still want to get one from DHCP. Those two options actually work together if you go for Address Mode == DHCP.
There was a problem hiding this comment.
Currently in our dialogs these fields are only visible if you select "static", right?
There was a problem hiding this comment.
@bdunne No, they are visible no matter which Address Mode is selected. If they were visible only with "static" Address Mode selected, then your original proposal would be without doubt the right way to go.
This PR was created because I think that example Customization Template that is provided for cloud-init provisioning on oVirt does not work as expected. Here are my points:
eth0, but if you provision e.g. RHEL7 VM, the default connection for eth device is calledSystem eth0. My PR takes this into account and should work with any eth connection