Add an association for Datacenters #17821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datacenters are a subclass of EmsFolder but have their own inventory collection. This will allow us use the standard association attribute for an inventory_collection rather than having to define a custom arel like Ovirt does today.
|
Checked commit agrare@516ed3c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/ext_management_system.rb
|
|
|
|
@kbrock yeah since datacenter is a subclass any dependent destroy will be handled by the ems_folders association |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datacenters are a subclass of EmsFolder but have their own inventory
collection. This will allow us use the standard association attribute
for an inventory_collection rather than having to define a custom arel
like Ovirt does today ref.