Add support for load_values_on_init to text boxes. #17814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for dynamic text and text area boxes for load_values_on_init to be respected when show refresh button is true. This allows dynamic text boxes to not load on init similar to dialog_field_sorted_item used by drop downs and radio buttons.
eclarizio
suggested changes
Aug 9, 2018
|
Checked commits jeffmcutter/manageiq@b241c16~...ac15dfd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
eclarizio
approved these changes
Aug 10, 2018
|
@jeffmcutter I'm marking this as a bug. If you feel it needs to be back-ported to the gaprindashvili branch can you please open a BZ and we'll associate it to these changes. |
|
@gmcculloug I have BZ 1613987 open for this issue, will that do the trick? I definitely need it back-ported, so if not let me know I can do another one. Thanks! |
|
That's what I needed, thanks. |
simaishi
pushed a commit
that referenced
this pull request
Sep 11, 2018
…pport_for_text_boxes Add support for load_values_on_init to text boxes. (cherry picked from commit 43a9146) https://bugzilla.redhat.com/show_bug.cgi?id=1623560
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for dynamic text and text area boxes for load_values_on_init to be respected when show refresh button is true.
This allows dynamic text boxes to not load on init similar to dialog_field_sorted_item used by drop downs and radio buttons.
https://bugzilla.redhat.com/show_bug.cgi?id=1613987