[GAPRINDASHVILI] Set checkbox on load, sans default, to be false, not nil

[d-m-u]

Non-dynamic dialog field checkboxes without a default should load with value false, not nil.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610685

[d-m-u]

@miq-bot add_label bug
@miq-bot assign @gmcculloug
@miq-bot add_reviewer @eclarizio
@miq-bot add_reviewer @tinaafitz

[d-m-u]

Uuum, I'mma say that @options.cumulative_rate_calculation? ? rates.sort_by(&:description) : unique_rates_by_tagged_resources(rates, metric_rollup_record_tags) failing has absolutely nothing to do with any of this code.

[eclarizio]

#initialize_value_context isn't meant to return a value, it's just meant to set up the @value instance variable. I think your specs need to call the method, and then you should simply be able to call dialog_field.value to check that the value was properly assigned. That was the my main goal of using the #initialize_value_context, since #value used to be used as not only a getter but also with a bunch of logic that we didn't want in there executing when we weren't sure it was executing.

[eclarizio]

I know this has to do with our wonky "t" or "f", but it's kind of confusing that we're expecting a be_truthy for an "f". Technically, that's correct, but it's also correct if the default value is a "t" (as shown in the next spec down).

I think both of those specs should probably be changed from be_truthy to what the value is really supposed to be.

[miq-bot]

Checked commit d-m-u@6192982 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[d-m-u]

Once again, I'mma say that Failure/Error: expect(subject.fixed_compute_1_cost).to be_within(0.01).of(hourly_rate * hours_in_month) expected 4.8 to be within 0.01 of 7.2 has absolutely zip to do with this code.

[eclarizio]

Agreed, not sure why that one spec is failing.

¯\_(ツ)_/¯

[simaishi]

@d-m-u Just noticed this PR... is there a corresponding 'master' PR for this?

[d-m-u]

@simaishi No, one isn't necessary, I believe it works on master.