Cleanup Ansible::Runner #17808
Merged
Cleanup Ansible::Runner #17808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
cleanup_ansible_runner
branch
2 times, most recently
from
bcf0405 to
7202f09
Compare
agrare
force-pushed
the
cleanup_ansible_runner
branch
2 times, most recently
from
4be0749 to
527f68f
Compare
agrare
reviewed
Aug 7, 2018
lib/ansible/runner.rb
Outdated
| playbook = playbook_or_role_args[:playbook] | ||
| errors << "playbook path doesn't exist: #{playbook}" if playbook && !File.exist?(playbook) | ||
| role = playbook_or_role_args[:role] | ||
| errors << "role path doesn't exist: #{role}" if role && !File.exist?(role) |
There was a problem hiding this comment.
I think this one is a valid test failure, previously this checked for the existence of roles_path and role is just the name of the role not a path.
There was a problem hiding this comment.
Yup my mistake. This is why I love specs :D
The main cleanup in this commit is to properly leverage AwesomeSpawn's params instead of manually building parts of the command line. Additionally, this fixes a bug with the :cmdline substitution when an extra_var has a "'" in it. Additionally, parameter validation has been lumped together to raise a single error to the caller, instead of one-by-one, and it also raises the more specific ArgumentError.
Fryguy
force-pushed
the
cleanup_ansible_runner
branch
from
25f39c1 to
abf0e51
Compare
|
Cleaned up some rubocops. @gtanzillo This should be good to go. |
|
Checked commits Fryguy/manageiq@494b8aa~...abf0e51 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/lib/ansible/runner_spec.rb
|
|
❤️ thanks for the specs guys :-D If we can get runner to the CI, we could add also integration specs (actually invoking ansible-runner), so we know the runner interface is not broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main cleanup in this commit is to properly leverage AwesomeSpawn's
params instead of manually building parts of the command line. Additionally,
this fixes a bug with the :cmdline substitution when an extra_var has a "'"
in it.
Additionally, parameter validation has been lumped together to raise a
single error to the caller, instead of one-by-one, and it also raises
the more specific ArgumentError.
@agrare As discussed. I'll give you access to push the specs into here.