Save Aws Region in File Depot for DB Backup #17803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
reviewed
Aug 6, 2018
app/models/miq_schedule.rb
Outdated
| depot = file_depot.class.name == depot_class ? file_depot : build_file_depot(:type => depot_class) | ||
| depot.name = params[:name] | ||
| depot.uri = params[:uri] | ||
| # depot.aws_region = params[:aws_region] |
The AWS region for S3 file depots was not being saved when passed in from the UI.
jerryk55
force-pushed
the
s3_file_depot_save_aws_region
branch
from
f6f5b2e to
769ad21
Compare
|
Also, is |
|
Checked commit jerryk55@769ad21 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS region for S3 file depots was not being saved when passed in from the UI.
In coordination with ManageIQ/manageiq-ui-classic#4300 which is setting the AWS region from a drop down list, we need to set the region in the file_depot for S3 DB backups.
@h-kataria @roliveri @carbonin @NickLaMuro fyi & review.
Links